Subtree sync for rustc_codegen_cranelift #149776

bjorn3 · 2025-12-08T16:26:32Z

The main highlights this time are a Cranelift update and adding actual support for -Cdebuginfo=line-tables-only rather than treating it the same as -Cdebuginfo=full.

r? @ghost

@rustbot label +A-codegen +A-cranelift +T-compiler

…clif-2025-11-08

…=BoxyUwU Add `overflow_checks` intrinsic This adds an intrinsic which allows code in a pre-built library to inherit the overflow checks option from a crate depending on it. This enables code in the standard library to explicitly change behavior based on whether `overflow_checks` are enabled, regardless of the setting used when standard library was compiled. This is very similar to the `ub_checks` intrinsic, and refactors the two to use a common mechanism. The primary use case for this is to allow the new `RangeFrom` iterator to yield the maximum element before overflowing, as requested [here](rust-lang#125687 (comment)). This PR includes a working `IterRangeFrom` implementation based on this new intrinsic that exhibits the desired behavior. [Prior discussion on Zulip](https://rust-lang.zulipchat.com/#narrow/stream/219381-t-libs/topic/Ability.20to.20select.20code.20based.20on.20.60overflow_checks.60.3F)

Improve type safety by using an enum rather than strings.

…e. (rust-lang#1604) * Only allocate the minimal alignment requested for a type when possible. * Code review: make an assertion a debug assert. Adjust an out-of-date comment.

This is far more accurate than filtering based on filename and as such allows building the sysroot a bit quicker. In addition the code is a bit simpler.

… coerce-lubs

…clif-2025-12-08

rustbot · 2025-12-08T16:26:36Z

The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging.

cc @davidtwco, @wesleywiser

rustbot · 2025-12-08T16:26:42Z

⚠️ Warning ⚠️

There are issue links (such as #123) in the commit messages of the following commits.
Please move them to the PR description, to avoid spamming the issues with references to the commit, and so this bot can automatically canonicalize them to avoid issues with subtree.
- 726b736
The following commits have merge commits (commits with multiple parents) in your changes. We have a no merge policy so these commits will need to be removed for this pull request to be merged.
- 154e158
- 1bd57eb
- 5873ee5
- 699fa9a
- b0d62eb
- d6eb3bd
- d7e4f9c
You can start a rebase with the following commands:
```
$ # rebase
$ git pull --rebase https://github.com/rust-lang/rust.git main
$ git push --force-with-lease
```

bjorn3 · 2025-12-08T16:26:46Z

@bors r+ p=1 subtree sync

bors · 2025-12-08T16:26:49Z

📌 Commit cb49fe5 has been approved by bjorn3

It is now in the queue for this repository.

…o filtering Reading the manifest doesn't work when running in the context of the rust build system.

bjorn3 · 2025-12-08T19:20:51Z

Had to revert 0670b60 because it broke in the context of bootstrap.

@bors r+ p=1 subtree sync

bors · 2025-12-08T19:20:55Z

📌 Commit 5a1936f has been approved by bjorn3

It is now in the queue for this repository.

bors · 2025-12-08T22:35:52Z

⌛ Testing commit 5a1936f with merge 0b96731...

bors · 2025-12-09T01:46:50Z

☀️ Test successful - checks-actions
Approved by: bjorn3
Pushing 0b96731 to main...

github-actions · 2025-12-09T01:49:47Z

What is this?

This is an experimental post-merge analysis report that shows differences in test outcomes between the merged PR and its parent PR.

Comparing 37aa213 (parent) -> 0b96731 (this PR)

Test differences

Show 2 test diffs

2 doctest diffs were found. These are ignored, as they are noisy.

Test dashboard

Run

cargo run --manifest-path src/ci/citool/Cargo.toml -- \
    test-dashboard 0b96731cd10757f695e99ba675ac26840ff85a79 --output-dir test-dashboard

And then open test-dashboard/index.html in your browser to see an overview of all executed tests.

Job duration changes

x86_64-mingw-1: 10372.2s -> 9425.1s (-9.1%)
i686-gnu-nopt-2: 7534.9s -> 8122.4s (+7.8%)
dist-i586-gnu-i586-i686-musl: 5760.5s -> 5334.1s (-7.4%)
dist-aarch64-apple: 7720.4s -> 8284.9s (+7.3%)
dist-aarch64-llvm-mingw: 6311.1s -> 5881.3s (-6.8%)
x86_64-gnu: 7189.2s -> 7669.2s (+6.7%)
pr-check-2: 2336.8s -> 2184.2s (-6.5%)
x86_64-gnu-miri: 4377.6s -> 4095.5s (-6.4%)
dist-armv7-linux: 5091.1s -> 5415.1s (+6.4%)
dist-various-2: 2182.5s -> 2303.5s (+5.5%)

How to interpret the job duration changes?

Job durations can vary a lot, based on the actual runner instance
that executed the job, system noise, invalidated caches, etc. The table above is provided
mostly for t-infra members, for simpler debugging of potential CI slow-downs.

rust-timer · 2025-12-09T02:58:06Z

Finished benchmarking commit (0b96731): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results (primary 2.3%, secondary 1.9%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	2.3%	[2.3%, 2.3%]	1
Regressions ❌ (secondary)	6.8%	[6.8%, 6.8%]	1
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-3.0%	[-3.0%, -3.0%]	1
All ❌✅ (primary)	2.3%	[2.3%, 2.3%]	1

Cycles

Results (primary 3.9%, secondary 0.8%)

A less reliable metric. May be of interest, but not used to determine the overall result above.

	mean	range	count
Regressions ❌ (primary)	3.9%	[3.9%, 3.9%]	1
Regressions ❌ (secondary)	2.5%	[2.1%, 2.9%]	2
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	3.9%	[3.9%, 3.9%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 470.452s -> 471.709s (0.27%)
Artifact size: 389.00 MiB -> 389.01 MiB (0.00%)

pitaj and others added 30 commits October 25, 2025 14:30

refactor ub_checks and contract_checks to share logic

482feee

Merge commit 'a0b865dc8782500efe9623859017dd5e16f85407' into sync_cg_…

c90a9d8

…clif-2025-11-08

Merge branch 'sync_from_rust'

1bd57eb

Add missing --check-cfg

9d292ca

Add missing --check-cfg

a44af2b

rustc_target: hide TargetOptions::vendor

35a99c1

rustc_target: introduce Abi

032ba98

Improve type safety by using an enum rather than strings.

rustc_target: introduce Env

46f2759

Improve type safety by using an enum rather than strings.

rustc_target: introduce Os

d1c33c3

Improve type safety by using an enum rather than strings.

Adjust for rust-lang/rust default branch rename

a842469

Sync from rust b6d7ff3

699fa9a

Rustup to rustc 1.93.0-nightly (b6d7ff3 2025-11-14)

614349a

Only allocate the minimal alignment requested for a type when possibl…

726b736

…e. (rust-lang#1604) * Only allocate the minimal alignment requested for a type when possible. * Code review: make an assertion a debug assert. Adjust an out-of-date comment.

Remove usage of function const promotion in the build system

2017344

Replace OffsetOf by an actual sum.

94ff1de

Sync from rust 3d461af

d6eb3bd

Rustup to rustc 1.93.0-nightly (3d461af 2025-11-18)

98bf9c4

Remove no longer necessary portable-simd patch

8ad6e38

Use the rust-std manifest file in build_llvm_sysroot_for_triple

0670b60

This is far more accurate than filtering based on filename and as such allows building the sysroot a bit quicker. In addition the code is a bit simpler.

Make it clearer what exactly is being benchmarked

53f8a7b

Update to Cranelift 0.126

0696294

Minor benchmarking improvements

fb32ac4

Rustup to rustc 1.93.0-nightly (c86564c 2025-11-27)

7cd6922

account for safe target features in fndef<->closure and fndef<->fndef…

85cf282

… coerce-lubs

Sync from rust ba2142a

b0d62eb

Rustup to rustc 1.94.0-nightly (ba2142a 2025-12-07)

29d4cba

Fix rustc testsuite

5139ab4

Fix Cirrus CI

fd6e372

Fix gimli assertion for anonymous sources

ba27d3d

bjorn3 added 2 commits December 8, 2025 16:20

Merge commit 'e24f0fa3c54951d1a5843b54ebe052faaa3a3cd2' into sync_cg_…

d7e4f9c

…clif-2025-12-08

Update list of allowed cg_clif dependencies

cb49fe5

rustbot added has-merge-commits PR has merge commits, merge with caution. S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 8, 2025

This comment has been minimized.

Sign in to view

Revert build_llvm_sysroot_for_triple back from reading the manifest t…

5a1936f

…o filtering Reading the manifest doesn't work when running in the context of the rust build system.

bors added the merged-by-bors This PR was explicitly merged by bors. label Dec 9, 2025

bors merged commit 0b96731 into rust-lang:main Dec 9, 2025
12 checks passed

rustbot added this to the 1.94.0 milestone Dec 9, 2025

bors mentioned this pull request Dec 9, 2025

Overhaul filename handling for cross-compiler consistency #149709

Open

bjorn3 deleted the sync_cg_clif-2025-12-08 branch December 9, 2025 08:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Uh oh!

Subtree sync for rustc_codegen_cranelift #149776

Subtree sync for rustc_codegen_cranelift #149776

Uh oh!

bjorn3 commented Dec 8, 2025

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

bjorn3 commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

This comment has been minimized.

bjorn3 commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2025

Uh oh!

rust-timer commented Dec 9, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants

Uh oh!

Subtree sync for rustc_codegen_cranelift #149776

Subtree sync for rustc_codegen_cranelift #149776

Uh oh!

Conversation

bjorn3 commented Dec 8, 2025

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

rustbot commented Dec 8, 2025

Uh oh!

bjorn3 commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

This comment has been minimized.

bjorn3 commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

bors commented Dec 8, 2025

Uh oh!

bors commented Dec 9, 2025

Uh oh!

Uh oh!

github-actions bot commented Dec 9, 2025

Test differences

Job duration changes

Uh oh!

rust-timer commented Dec 9, 2025

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

11 participants